Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds richer, persisted context-doc generation metadata (requestedAt, source, event, reason, provider, modelId, reasoningEffort), introduces "pending" and "succeeded" states, refactors generation flows to record and merge run metadata, and updates tests and UI to treat "pending" as an active generation state. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
apps/desktop/src/renderer/components/settings/ContextSection.tsx (2)
239-244: Minor inefficiency:describeGenerationSourcecalled twice.The function is called once for the condition check and again for string interpolation. Consider storing the result in a variable.
♻️ Suggested optimization
{isContextGenerationActive(docsStatus?.generation) ? ( - <div style={{ fontFamily: SANS_FONT, fontSize: 11, color: COLORS.info, padding: "8px 12px", borderRadius: 8, background: `${COLORS.info}08`, border: `1px solid ${COLORS.info}18` }}> - Context docs are being generated. This may take a minute depending on your model and project size. - {describeGenerationSource(docsStatus?.generation) ? ` ${describeGenerationSource(docsStatus?.generation)}` : ""} - </div> + (() => { + const sourceDesc = describeGenerationSource(docsStatus?.generation); + return ( + <div style={{ fontFamily: SANS_FONT, fontSize: 11, color: COLORS.info, padding: "8px 12px", borderRadius: 8, background: `${COLORS.info}08`, border: `1px solid ${COLORS.info}18` }}> + Context docs are being generated. This may take a minute depending on your model and project size. + {sourceDesc ? ` ${sourceDesc}` : ""} + </div> + ); + })() ) : null}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/components/settings/ContextSection.tsx` around lines 239 - 244, Store the result of describeGenerationSource(docsStatus?.generation) in a local variable (e.g., generationSource) and use that variable both for the truthy check and for the string interpolation inside the JSX; update the conditional that currently uses isContextGenerationActive(docsStatus?.generation) and the inner interpolation to reference the saved generationSource so describeGenerationSource is called only once and the value is reused.
49-66: Consider extracting shared helpers.The
isContextGenerationActivefunction is duplicated fromProjectSetupPage.tsx. Consider extracting both helpers to a shared utility file (e.g.,lib/contextUtils.ts) to maintain DRY principles and ensure consistent behavior.♻️ Example shared utility
// lib/contextUtils.ts import type { ContextStatus } from "../../shared/types"; export function isContextGenerationActive( status: ContextStatus["generation"] | null | undefined ): boolean { return status?.state === "pending" || status?.state === "running"; } export function describeGenerationSource( status: ContextStatus["generation"] | null | undefined ): string | null { if (!status || !isContextGenerationActive(status)) return null; if (status.source !== "auto") return null; // ... switch cases }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/components/settings/ContextSection.tsx` around lines 49 - 66, Extract the duplicated helpers isContextGenerationActive and describeGenerationSource into a shared utility module (e.g., contextUtils.ts) and replace the local implementations in ContextSection.tsx and ProjectSetupPage.tsx with imports from that module; ensure the exported functions keep the same signatures and behavior (including the switch cases in describeGenerationSource and the status?.state checks in isContextGenerationActive) so callers can simply import { isContextGenerationActive, describeGenerationSource } and use them unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/desktop/src/renderer/components/settings/ContextSection.tsx`:
- Around line 239-244: Store the result of
describeGenerationSource(docsStatus?.generation) in a local variable (e.g.,
generationSource) and use that variable both for the truthy check and for the
string interpolation inside the JSX; update the conditional that currently uses
isContextGenerationActive(docsStatus?.generation) and the inner interpolation to
reference the saved generationSource so describeGenerationSource is called only
once and the value is reused.
- Around line 49-66: Extract the duplicated helpers isContextGenerationActive
and describeGenerationSource into a shared utility module (e.g.,
contextUtils.ts) and replace the local implementations in ContextSection.tsx and
ProjectSetupPage.tsx with imports from that module; ensure the exported
functions keep the same signatures and behavior (including the switch cases in
describeGenerationSource and the status?.state checks in
isContextGenerationActive) so callers can simply import {
isContextGenerationActive, describeGenerationSource } and use them unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fcd0eddd-5d8a-4191-b159-f5b2ef718dc1
📒 Files selected for processing (7)
apps/desktop/src/main/services/context/contextDocBuilder.tsapps/desktop/src/main/services/context/contextDocService.test.tsapps/desktop/src/main/services/context/contextDocService.tsapps/desktop/src/renderer/components/app/AppShell.tsxapps/desktop/src/renderer/components/onboarding/ProjectSetupPage.tsxapps/desktop/src/renderer/components/settings/ContextSection.tsxapps/desktop/src/shared/types/packs.ts
arul28
force-pushed
the
ade/doc-generation-ee96fad9
branch
from
55f6c0b to
036d998
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/desktop/src/renderer/components/onboarding/ProjectSetupPage.tsx`:
- Around line 74-75: The helper hasReadyContextDocs currently uses
status?.docs?.every(...), which returns true for empty arrays and thus wrongly
reports readiness when status.docs is []; update hasReadyContextDocs to first
check that status?.docs exists and has length > 0, then apply docs.every(doc =>
doc.exists && doc.sizeBytes >= 200) so empty arrays are treated as not ready;
modify the function that takes (status: ContextStatus | null) accordingly and
ensure any callers (e.g., the UI branch around "Both docs are present") rely on
the updated helper.
In `@apps/desktop/src/renderer/components/settings/ContextSection.tsx`:
- Around line 239-243: The UI currently treats docsStatus?.generation with state
"pending" as already "being generated"; update the user-facing copy to branch on
generation.state instead of using isContextGenerationActive for messaging: when
docsStatus?.generation?.state === "pending" show "queued" or "starting" wording
(e.g., "Context docs are queued and will start shortly"), and only show "being
generated"/"generating…" when docsStatus?.generation?.state === "running" (use
describeGenerationSource for extra context). Apply the same change in
ProjectSetupPage where generation status text is shown so polling/disable logic
can keep using "pending" but the displayed text reflects "queued" vs "running".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b63621cc-d763-4568-a7df-1f0cee72a866
📒 Files selected for processing (7)
apps/desktop/src/main/services/context/contextDocBuilder.tsapps/desktop/src/main/services/context/contextDocService.test.tsapps/desktop/src/main/services/context/contextDocService.tsapps/desktop/src/renderer/components/app/AppShell.tsxapps/desktop/src/renderer/components/onboarding/ProjectSetupPage.tsxapps/desktop/src/renderer/components/settings/ContextSection.tsxapps/desktop/src/shared/types/packs.ts
✅ Files skipped from review due to trivial changes (1)
- apps/desktop/src/main/services/context/contextDocBuilder.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- apps/desktop/src/renderer/components/app/AppShell.tsx
- apps/desktop/src/main/services/context/contextDocService.test.ts
- apps/desktop/src/shared/types/packs.ts
- apps/desktop/src/main/services/context/contextDocService.ts
apps/desktop/src/renderer/components/onboarding/ProjectSetupPage.tsx
Outdated
Show resolved
Hide resolved
arul28
force-pushed
the
ade/doc-generation-ee96fad9
branch
from
9d407f9 to
4a89230
Compare
arul28
force-pushed
the
ade/doc-generation-ee96fad9
branch
from
4a89230 to
ab2bbeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Tests