fix: validate length parameter value and use avg month calculation#10
Open
Hitchhiker007 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! These are the changes I made.
Invalid length parameter returns undefined
Passing an invalid length value like "long" would silently return undefined instead of throwing an error. So I added a value check after the existing type check to throw a descriptive error for any value other than "null", "short", or "shorter".
Changed month calculation
The month unit was using 2,419,200 seconds (28 days) as its base. I updated it to 2,629,800 seconds, which reflects the average month length of 30.44 days (365.25 days ÷ 12), which accounts for leap years.