Raise ValueError for negative numbers in dehumanize()#1302
Open
awath-abdat wants to merge 1 commit into
Open
Conversation
dehumanize() silently dropped the minus sign from inputs like "in -1 hours" because the number-extraction regex (\d+) only matches unsigned digits. This produced quietly wrong results.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1302 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2317 +2
Branches 358 359 +1
=========================================
+ Hits 2315 2317 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
masterbranch.Description of Changes
Closes: #1278
dehumanize()silently dropped the minus sign from inputs like"in -1 hours"because the number-extraction regex (\d+) only matches unsigned digits. The result was that"in -1 hours"produced the same output as"in 1 hours"— a quietly wrong datetime in the opposite direction from what a user would expect.Since humanized time strings express direction via
"ago"/"in"rather than arithmetic signs, negative numbers are never valid input. This PR adds an early validation check that raisesValueErrorwhen the input contains a negative number (e.g.-1,- 2).Added
test_negative_numberscovering three variants:"in -1 hours","-3 minutes ago", and"in -2 days". All 23 dehumanize tests pass.