Make alphabetic keys in the virtual keyboard vibrate.#3046
Open
IsaacOscar wants to merge 1 commit into
Open
Conversation
This just copies the code from _Mathfield.insert, which also does the same thing as performWithFeedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very simple fix makes alphabetic keys on the default virtual keyboard layout vibrate in the same way as the other keys.
In particular, I just modified the code of
onInputto be consistent with it's own comments, and the feedback option ofMathField.insert.