lib / kernel-debs: add Conflicts:linux-image to kernel deb pkg#9095
lib / kernel-debs: add Conflicts:linux-image to kernel deb pkg#9095leggewie wants to merge 1 commit intoarmbian:mainfrom
Conversation
we do not want the user to install an upstream kernel package
WalkthroughThe change adds a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (11)📚 Learning: 2025-09-27T21:47:58.020ZApplied to files:
📚 Learning: 2025-09-27T21:50:04.845ZApplied to files:
📚 Learning: 2025-04-30T16:16:47.150ZApplied to files:
📚 Learning: 2025-11-10T22:05:40.490ZApplied to files:
📚 Learning: 2025-06-25T03:42:09.086ZApplied to files:
📚 Learning: 2025-05-05T12:35:07.143ZApplied to files:
📚 Learning: 2025-08-21T08:10:59.502ZApplied to files:
📚 Learning: 2025-06-24T10:08:40.313ZApplied to files:
📚 Learning: 2025-11-02T20:49:56.719ZApplied to files:
📚 Learning: 2025-12-12T23:10:00.819ZApplied to files:
📚 Learning: 2025-09-14T06:29:18.958ZApplied to files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rpardini
left a comment
There was a problem hiding this comment.
Absolutely not. One can have as many linux-image's as one wants.
|
It is/was my understanding that this is Armbian policy. Only a single kernel and only an Armbian kernel. @igorpecovnik Can you clarify? I am happy to close this PR once it is clear what Armbian policy actually is. It is my recollection that you made a statement somewhere, possibly in a private chat, along the lines of what I characterized above. And I can certainly see an argument to be made for something like it, just like I can also see an argument be made against it. |
|
To my understanding it was never a policy that there must be one kernel only. We just never went into multi-kernel-world on stock images. |
That, well said. |
|
Reiterate: all images using GRUB ( Building with All upstream Debian and all upstream Ubuntu allow for multiple kernels. absolutely nothing is gained by adding this restriction. I can't fathom why were still discussing it. It also appears in different PRs in other forms. |
|
Then closing now. |
we do not want the user to install an upstream kernel package
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.