fix(anta): Add Semaphore to AsyncEOSDevice#1042
Merged
carl-baillargeon merged 4 commits intoaristanetworks:mainfrom Feb 21, 2025
Merged
fix(anta): Add Semaphore to AsyncEOSDevice#1042carl-baillargeon merged 4 commits intoaristanetworks:mainfrom
carl-baillargeon merged 4 commits intoaristanetworks:mainfrom
Conversation
CodSpeed Performance ReportMerging #1042 will not alter performanceComparing Summary
|
|
gmuloc
approved these changes
Feb 21, 2025
Contributor
gmuloc
left a comment
gmuloc
left a comment
There was a problem hiding this comment.
as discussed it LGTM - lets see if/how we can switch to another library for more perf in a future PR
Contributor
|
that being said - would be cool if we manage to get a benchmark for this kind of stuff running somewhere.. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Semaphore of 100 per device to avoid sending too many commands/requests to HTTPX. HTTPX has a default max_connections of 100 so we respect that to avoid high-concurrency performance issues.
Related to:
https://github.com/encode/httpx/issues/3215
encode/httpcore#928
encode/httpcore#929
Benchmarks on i7-12800H, 32GB RAM, 1048576 file descriptors
With Semaphore:
Without Semaphore:
Checklist:
pre-commit run)tox -e testenv)