Bump Plonky3 and add prover cost analysis#46
Merged
arthurpaulino merged 2 commits intomainfrom Mar 30, 2026
Merged
Conversation
- Implement `Dup` trait for `SymbolicExpression<F>` (new bound on `PrimeCharacteristicRing`) - Rename `packed_linear_combination` to `batched_linear_combination` with updated signature - Fix imports: add `Algebra` + `Dup`, remove unused `PackedField`
…notations Document the prover's computational cost model in the module docstring, covering all five phases: stage 1 commit, lookup trace construction, stage 2 commit, quotient computation/commit, and FRI opening. Includes notation, concrete formulas, and dominant-term analysis. Add inline cost comments at each key step in prove_multiple_claims.
gabriel-barrett
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e52636ectoe9d75614and adapt to breaking API changes:Duptrait forSymbolicExpression<F>(new bound onPrimeCharacteristicRing)packed_linear_combination→batched_linear_combinationwith updated signatureAlgebra+Dup, remove unusedPackedFieldprovermodule docstring, covering all five proving phases (stage 1 commit, lookup trace construction, stage 2 commit, quotient computation/commit, FRI opening) with notation, concrete formulas, and dominant-term analysisprove_multiple_claims