feat(argo-rollouts): make make automountServiceAccountToken configurable#3562
feat(argo-rollouts): make make automountServiceAccountToken configurable#3562bianchi2 wants to merge 9 commits intoargoproj:mainfrom
Conversation
bianchi2
changed the title
Signed-off-by: Yevhen Ivantsov <yivantsov@atlassian.com>
Signed-off-by: Yevhen Ivantsov <yivantsov@atlassian.com>
bianchi2
force-pushed
the
make-automountserviceaccounttoken-configurable
branch
from
dea347f to
79fe2c1
Compare
bianchi2
changed the title
| {{- if ne .Values.serviceAccount.automountServiceAccountToken nil }} | ||
| automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }} | ||
| {{- end }} |
There was a problem hiding this comment.
I want to follow the existing logics and default value in argo-helm. 😃
Ref:
There was a problem hiding this comment.
@yu-croco thanks, I wanted to keep default rendered templates as is but it indeed makes sense to set it to true provided that it's the default anyways and other argocd charts use this pattern. Just committed the change.
Signed-off-by: Yevhen Ivantsov <yivantsov@atlassian.com>
| @@ -20,3 +20,5 @@ annotations: | |||
| artifacthub.io/changes: | | |||
| - kind: changed | |||
Signed-off-by: Yevhen Ivantsov <yivantsov@atlassian.com>
bianchi2
force-pushed
the
make-automountserviceaccounttoken-configurable
branch
from
ca152d6 to
cf98c2c
Compare
Signed-off-by: Yevhen Ivantsov <yivantsov@atlassian.com>
bianchi2
force-pushed
the
make-automountserviceaccounttoken-configurable
branch
from
cf98c2c to
9e67275
Compare
| annotations: | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} | ||
| automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }} |
There was a problem hiding this comment.
In existing logic, deployment and Service have their own parameters.
https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/values.yaml#L971-L984
There was a problem hiding this comment.
Created controller.automountServiceAccountToken to use in deployment template.
| | podLabels | object | `{}` | Labels to be added to the Rollout pods | | ||
| | podSecurityContext | object | `{"runAsNonRoot":true}` | Security Context to set on pod level | | ||
| | serviceAccount.annotations | object | `{}` | Annotations to add to the service account | | ||
| | serviceAccount.automountServiceAccountToken | bool | `true` | Specifies whether a service account token should be automatically mounted into pods Defaults to true when unspecified. Set to 'false' if you are using projected tokens. | |
There was a problem hiding this comment.
We want to align the descriptions. 😄
argo-helm/charts/argo-cd/values.yaml
Lines 983 to 984 in 5aaa3bd
argo-helm/charts/argo-cd/values.yaml
Lines 971 to 972 in 5aaa3bd
Signed-off-by: Yevhen Ivantsov <yivantsov@atlassian.com>
|
@tico24 any chance to review this one? Thanks |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
2 participants
It's common that automountServiceAccountToken is enforced to false in enterprize clusters (token is mounted via projected volume). This PR makes it possible to set serviceAccount.automountServiceAccountToken to false.
Checklist: