Skip to content

Fix for ImageMagick 7 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dirk-zimoch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for ImageMagick 7 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions urlApp/src/URLDriver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,11 @@ asynStatus URLDriver::readImage()
break;
case 32:
dataType = NDUInt32;
#if MagickLibVersion >= 0x700
storageType = LongPixel;
#else
storageType = IntegerPixel;
#endif
Comment on lines +123 to +127

@ericonr ericonr Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer a solution using <type_traits> instead of hardcoding library version numbers, but it might be less understandable, so I'm okay with this version as well.

@dirk-zimoch dirk-zimoch Jul 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<type_traits> would require a C++11 compatible compiler. Not a very high hurdle nowadays but a new requirement.

@dirk-zimoch dirk-zimoch Jul 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it IS a version dependent change.

break;
default:
asynPrint(pasynUserSelf, ASYN_TRACE_ERROR,
Expand Down