Rename Serial objects if CDC UART is not available#471
Open
facchinm wants to merge 1 commit intoarduino:mainfrom
Open
Rename Serial objects if CDC UART is not available#471facchinm wants to merge 1 commit intoarduino:mainfrom
facchinm wants to merge 1 commit intoarduino:mainfrom
Conversation
|
Memory usage change @ 903d094
Click for full report table
Click for full report CSV |
Collaborator
|
@facchinm I think the alignment between the cores is crucial. I was rather thinking of On the variants which don't support it like the NSense. So, Serial would always map to the USB Serial port and the usage of |
Collaborator
|
@facchinm I think we add a bit to the confusion by referring to the UART ports on the pinout. E.g. the pinout of the Portenta H7 mentions UART1 on D13 and D14, so UART1 must be the same one used by the USB port I assume. So it can be accessed via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes arduino/nicla-sense-me-fw#55
@per1234 @sebromero does it look ok? I remember we had some conversation about the naming on platforms like PORTENTA_H7_M4, where we would lose the alignment between cores (the same pins would be referred as Serial on M4 and Serial1 on M7)