Fix duplicate maintainers on package pages (#427)#661
Open
m1rm wants to merge 1 commit intoarchlinux:masterfrom
Open
Fix duplicate maintainers on package pages (#427)#661m1rm wants to merge 1 commit intoarchlinux:masterfrom
m1rm wants to merge 1 commit intoarchlinux:masterfrom
Conversation
Member
|
Whats an example package where this bug occurs? 😊 |
Contributor
Author
The bug still appears here: https://archlinux.org/packages/extra/any/python-qt.py. I also tried reproducing it locally using the commands from the current README.md step no. 7 to load real prod data locally, but python-qt then was not found when running locally. So I assume it might be worth a thought providing some updated dumps (which would be a separate issue/todo ofc). I also think the distinct is rather a "workaround" then a real fix. I assume we would have to check prod tables and maybe do an according migration to clean up data actually causing the bug in the first place (out of my reach however). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #427
This pull requests appends .distinct() to the User queryset in Package.maintainers so each user is returned at most once, regardless of duplicate relation rows.