Skip to content

Make network configuration a mandatory menu selection #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Softer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make network configuration a mandatory menu selection #4408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de709d7
Make network configuration mandatory with explicit "No network" option
Softer Apr 11, 2026
14b5dcb
Add network configuration recommendation hint and disable sorting
Softer Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions archinstall/lib/global_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ def _get_menu_options(self) -> list[MenuItem]:
action=select_network,
value={},
preview_action=self._prev_network_config,
mandatory=True,
key='network_config',
),
MenuItem(
Expand Down
3 changes: 3 additions & 0 deletions archinstall/lib/models/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class NicType(Enum):
NM = 'nm'
NM_IWD = 'nm_iwd'
MANUAL = 'manual'
NONE = 'none'

def display_msg(self) -> str:
match self:
Expand All @@ -23,6 +24,8 @@ def display_msg(self) -> str:
return tr('Use Network Manager (iwd backend)')
case NicType.MANUAL:
return tr('Manual configuration')
case NicType.NONE:
return tr('No network')


class _NicSerialization(TypedDict):
Expand Down
2 changes: 2 additions & 0 deletions archinstall/lib/network/network_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ def install_network_config(
installation.configure_nic(nic)
installation.enable_service('systemd-networkd')
installation.enable_service('systemd-resolved')
case NicType.NONE:
pass


def _configure_nm_iwd(installation: Installer) -> None:
Expand Down
9 changes: 7 additions & 2 deletions archinstall/lib/network/network_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,17 @@ async def select_network(preset: NetworkConfiguration | None) -> NetworkConfigur
"""

items = [MenuItem(n.display_msg(), value=n) for n in NicType]
group = MenuItemGroup(items, sort_items=True)
group = MenuItemGroup(items, sort_items=False)

if preset:
group.set_selected_by_value(preset.type)

header = tr('Choose network configuration') + '\n'
header += tr('Recommended: Network Manager for desktop, Manual for server') + '\n'

result = await Selection[NicType](
group,
header=tr('Choose network configuration'),
header=header,
allow_reset=True,
allow_skip=True,
).show()
Expand All @@ -205,5 +208,7 @@ async def select_network(preset: NetworkConfiguration | None) -> NetworkConfigur

if nics:
return NetworkConfiguration(NicType.MANUAL, nics)
case NicType.NONE:
return NetworkConfiguration(NicType.NONE)

return preset
6 changes: 6 additions & 0 deletions archinstall/locales/base.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,9 @@ msgstr ""
msgid "Manual configuration"
msgstr ""

msgid "No network"
msgstr ""

msgid "Mark/Unmark a partition as compressed (btrfs only)"
msgstr ""

Expand Down Expand Up @@ -2029,6 +2032,9 @@ msgstr ""
msgid "Choose network configuration"
msgstr ""

msgid "Recommended: Network Manager for desktop, Manual for server"
msgstr ""

msgid "No packages found"
msgstr ""

Expand Down
6 changes: 6 additions & 0 deletions archinstall/locales/uk/LC_MESSAGES/base.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,9 @@ msgstr "Оберіть інтерфейс для додавання"
msgid "Manual configuration"
msgstr "Ручне налаштування"

msgid "No network"
msgstr "Без мережі"

msgid "Mark/Unmark a partition as compressed (btrfs only)"
msgstr "Позначити/зняти позначку розділу як стисненого (лише btrfs)"

Expand Down Expand Up @@ -1970,6 +1973,9 @@ msgstr "Оберіть інтерфейс"
msgid "Choose network configuration"
msgstr "Оберіть конфігурацію мережі"

msgid "Recommended: Network Manager for desktop, Manual for server"
msgstr "Рекомендовано: Network Manager для робочого столу, ручне налаштування для сервера"

msgid "No packages found"
msgstr "Пакети не знайдено"

Expand Down
Loading