Skip to content

Fix table column error #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svartkanin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix table column error #4406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions archinstall/tui/ui/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,20 @@ def _display_header(self, is_loading: bool) -> None:
header = self.query_one('#header_text', Label)
header.display = not is_loading

def _get_column_keys(self, items: list[MenuItem]) -> list[str]:
all_keys: list[str] = []
for item in items:
if item.value:
all_keys.extend(item.value.table_data().keys())

# Create unique list while preserving order
unique_keys: list[str] = list(dict.fromkeys(all_keys))

if self._multi:
unique_keys.insert(0, ' ')

return unique_keys

def _put_data_to_table(self, table: DataTable[ValueT], group: MenuItemGroup) -> None:
items = group.items
selected = group.selected_items
Expand All @@ -1024,15 +1038,7 @@ def _put_data_to_table(self, table: DataTable[ValueT], group: MenuItemGroup) ->
_ = self.dismiss(Result(ResultType.Selection))
return

value = items[0].value
if not value:
_ = self.dismiss(Result(ResultType.Selection))
return

cols = list(value.table_data().keys())

if self._multi:
cols.insert(0, ' ')
cols = self._get_column_keys(items)

table.add_columns(*cols)

Expand Down
Loading