report a switch name that matches no registration - #4
Merged
Conversation
Redis accepts any field, so a mistyped switch name was written, reported as applied, and never consulted — indistinguishable from a working pause until someone noticed the flow had never stopped. App now tells its SwitchBoard which names this process actually checks, and anything else is logged at ERROR. Checked both on set() and on every re-read: set() catches this process's own callers, the re-read catches whatever switches.disable() wrote from outside, which holds a short-lived connection, knows no topology, and so cannot check itself. Logged rather than raised — a process knows only the names it mounted, and in a split deployment a name may belong to a service running elsewhere. Reported once per name so a 2s refresh cannot turn one typo into a flood. Also fixes pytest collection: tests/ has no __init__.py, so pytest put that directory on sys.path instead of the project root and `from tests.helpers import ...` only resolved under `python -m pytest`. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis accepts any field, so a mistyped switch name was written, reported as applied, and never consulted — indistinguishable from a working pause until someone noticed the flow had never stopped.
App now tells its SwitchBoard which names this process actually checks, and anything else is logged at ERROR. Checked both on set() and on every re-read: set() catches this process's own callers, the re-read catches whatever switches.disable() wrote from outside, which holds a short-lived connection, knows no topology, and so cannot check itself.
Logged rather than raised — a process knows only the names it mounted, and in a split deployment a name may belong to a service running elsewhere. Reported once per name so a 2s refresh cannot turn one typo into a flood.
Also fixes pytest collection: tests/ has no init.py, so pytest put that directory on sys.path instead of the project root and
from tests.helpers import ...only resolved underpython -m pytest.