Skip to content

fix(release): stage desktop dependencies per architecture - #356

Merged
AprilNEA merged 4 commits into
masterfrom
xuan/code-516
Jul 31, 2026
Merged

fix(release): stage desktop dependencies per architecture#356
AprilNEA merged 4 commits into
masterfrom
xuan/code-516

Conversation

@AprilNEA

@AprilNEA AprilNEA commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

  • materialize one production staging directory per target CPU with pnpm deploy --cpu=<arch>
  • package x64 and ARM64 separately so each artifact carries only its matching napi-rs keyring binding
  • merge the separately generated macOS/Windows updater manifests while retaining x64 as the legacy fallback entry
  • keep Linux updater manifests architecture-specific

Root cause

The desktop release cross-packs x64 and ARM64 artifacts on one runner, while pnpm previously installed only the runner CPU's @napi-rs/keyring-* optional package. The opposite-architecture artifact therefore lacked its keyring binding, and all three v0.13.0 packaging jobs failed artifact verification.

Without that verification, affected builds would silently fall back to plaintext daemon credential storage.

Verification

  • x64 pnpm deploy --cpu=x64 staging contains only the Darwin x64 keyring binding
  • ARM64 pnpm deploy --cpu=arm64 staging contains only the Darwin ARM64 keyring binding
  • updater manifest merge regression test
  • pnpm check:ci
  • pnpm test — 2235 passed, 1 skipped
  • Build Desktop run 30624768061 — macOS, Windows, and Linux packaging, artifact verification, and uploads passed

Linear: CODE-516

@linear-code

linear-code Bot commented Jul 31, 2026

Copy link
Copy Markdown

CODE-516

@AprilNEA AprilNEA changed the title fix(release): install both CPU keyring bindings fix(release): stage desktop dependencies per architecture Jul 31, 2026
@AprilNEA
AprilNEA marked this pull request as ready for review July 31, 2026 11:08
@AprilNEA
AprilNEA merged commit 524b76e into master Jul 31, 2026
13 checks passed
@AprilNEA
AprilNEA deleted the xuan/code-516 branch July 31, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant