fix(orchestrator): define the tier-1/tier-2 boundary so resolved intent routes instead of asking - #598
Open
SUaDtL wants to merge 3 commits into
Open
fix(orchestrator): define the tier-1/tier-2 boundary so resolved intent routes instead of asking#598SUaDtL wants to merge 3 commits into
SUaDtL wants to merge 3 commits into
Conversation
…nt routes instead of asking CHANGELOG: the orchestrator no longer asks "did you mean" when it has already resolved the exact command and its complete argument — fully-resolved, non-destructive intent routes directly (ADR-0022 tier 1) Claude-Session: https://claude.ai/code/session_01QjJeSbcwPHwMmd6CEZeagB
Required by ca-pi's release guard (tools/build-host-packages.py --release-guard-base), which enforces a changelog entry alongside any version advance. Claude-Session: https://claude.ai/code/session_01QjJeSbcwPHwMmd6CEZeagB
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
…DME and CHANGELOG.md The version-gate PR bumped plugins/ca and plugins/ca-codex manifests without updating the three surfaces derived from them: the README version badge, the README "currently ships `ca-codex ...`" line the site generator test asserts against, and ca's CHANGELOG.md top section, which the release-trace hook contract requires to equal the manifest version. CHANGELOG: no user-facing behavior change beyond the prior commit's fix; this corrects the README badge/ships-line and adds ca's CHANGELOG.md section to match the version bump already shipped Claude-Session: https://claude.ai/code/session_01QjJeSbcwPHwMmd6CEZeagB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORCHESTRATOR.md§6 never defined the tier-1/tier-2 boundary (ADR-0022) operationally, so a cautious host model (observed on codex) answered a fully-resolved intent with tier 2's "did you mean$feature "F-137 …"?" — displaying the exact command and complete argument while asking permission to run it. That is the retype ceremony ADR-0022 abolished, wearing a question mark.This edits
core/surface/ORCHESTRATOR.md§6 to:Regenerated via
tools/build-surface.pyinto all three host renders (plugins/ca,plugins/ca-codex,plugins/ca-pi), each with correct per-host command spellings (/ca:fix,$ca-fix,/ca-fix).Does not contradict ADR-0022 — it sharpens "unambiguous" operationally without touching the risk axis, which the next paragraph ("Clarity and risk are separate axes") still owns.
Before / after (core/surface/ORCHESTRATOR.md §6)
Before:
After:
Verification
python tools/build-surface.pythen--check: OK (claude, codex, pi in sync)python tools/sync-core.py --check: OK (56 core files x 3 plugins, byte-identical)python .github/scripts/test_build_surface.py: 40/40 OK (pytest unavailable in this environment; run directly as unittest, which the module supports)plugins/ca/hooks/tests(NO_COLOR unset), viapython -m unittest discover: 1308 tests, 5 failures / 5 errors — proven pre-existing and identical (same 10 test names) on a stashed cleanorigin/mainbaseline in this same worktree. All ten are intest_git_hooks.py/test_repo_resolution.py, about the git-level enforcer drop-in registration and Windows symlink creation, and are caused by running from a linked worktree, not by this diff.python .github/scripts/payload_version_gate.py --plugin plugins/ca --base origin/main: shipped payload changed and version advanced 2.11.1 -> 2.11.4python .github/scripts/payload_version_gate.py --plugin plugins/ca-codex --base origin/main: shipped payload changed and version advanced 0.4.0 -> 0.4.3python tools/build-host-packages.py --checkand--release-guard-base origin/main(ca-pi's own gate, per.codearbiter/release-targets.md): Pi payload, version, changelog, and root metadata advanced together 0.2.0 -> 0.2.3git diff --check origin/main..HEAD: clean, no CR/whitespace errorsDeviations
plugins/ca-pi/CHANGELOG.mdentry (added in a second commit) to satisfy its own release guard, which enforces changelog + root-manifest synchronization on any version advance — this wasn't spelled out in the task brief but is required by the declaredpre-taggate for that plugin.Closes #595
https://claude.ai/code/session_01QjJeSbcwPHwMmd6CEZeagB