fix(site): align guarantee cards - #590
Merged
Merged
Conversation
The fallback assertion compares whole renders, so the bounded dirty probe could change an unrelated branch marker between calls. Pin that probe to keep the test focused on palette compatibility.
Starlight's sibling flow spacing adds block-start margin to later cards, creating a staggered row. Reset that margin at the card boundary so grid gap remains the only inter-card spacing. CHANGELOG: Align guarantee cards across responsive layouts.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Fresh CI runners could not resolve a feature-branch-only historical SHA, while repeated render tests sampled a latency-bounded Git probe between comparisons. Pin a reachable byte-identical baseline, isolate the live probe in test fixtures, and advance the shipped CA payload version. CHANGELOG: Restore cross-platform hook CI and stable statusline regression checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2.11.1with synchronized public version surfaces.Why
Starlight's layered sibling flow spacing adds a top margin to later card siblings, which staggered the guarantee row. Repeated statusline tests also sampled a latency-bounded Git probe between whole-render comparisons. Separately, the release trace pinned a feature-branch-only commit that remained available in long-lived local clones but could not exist in fresh CI clones.
Verification
npm testinsite: 512 tests passed.npm run coverageinsite: 70.83% lines and 70.19% branches.npm run typecheckinsite.npm run buildinsite: 134 pages built.npm audit --omit=dev --audit-level=highinsite: zero vulnerabilities.2.11.0 -> 2.11.1accepted.Tradeoff
The statusline tests pin
git_dirtyinstead of extending the production 100 ms timeout. This preserves the UI latency boundary while isolating the render contracts (conflict hierarchy: correctness, level 2, over incidental integration coverage).Review note
A computed-style browser test across responsive breakpoints remains a non-blocking coverage improvement. The current CSS behavior and source-level regression are verified.