Skip to content

feat(schema): add database schema config#1129

Open
serrovsky wants to merge 6 commits intoaquasecurity:mainfrom
serrovsky:feat/add-schema-to-db
Open

feat(schema): add database schema config#1129
serrovsky wants to merge 6 commits intoaquasecurity:mainfrom
serrovsky:feat/add-schema-to-db

Conversation

@serrovsky
Copy link
Copy Markdown
Contributor

With this configuration, you can select database schema. This setting could be good when you want to share the same Postgres instance for different clusters validations.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2022

Codecov Report

Merging #1129 (f76b70a) into main (70a544e) will decrease coverage by 0.60%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   63.86%   63.26%   -0.61%     
==========================================
  Files          12       12              
  Lines        1882     1900      +18     
==========================================
  Hits         1202     1202              
- Misses        619      637      +18     
  Partials       61       61              
Impacted Files Coverage Δ
cmd/database.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a544e...f76b70a. Read the comment docs.

Comment thread cmd/database.go Outdated
@mozillazg
Copy link
Copy Markdown
Contributor

@luis-serra-ki Thanks for your contribution!

@serrovsky serrovsky requested a review from mozillazg March 28, 2022 11:55
Comment thread cmd/database.go Outdated
Comment thread cmd/database.go
@serrovsky serrovsky requested a review from mozillazg March 28, 2022 20:59
Comment thread cmd/database.go
Comment on lines +61 to +66
if value := viper.GetString("PGSQL_SCHEMA"); value != "" {
schema = value
} else {
schema = ""
glog.V(2).Info("No schema set.")
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if value := viper.GetString("PGSQL_SCHEMA"); value != "" {
schema = value
} else {
schema = ""
glog.V(2).Info("No schema set.")
}
schema = viper.GetString("PGSQL_SCHEMA")

Comment thread cmd/database.go
db, err := gorm.Open(postgres.Open(PsqlConnInfo.toString()), &gorm.Config{})
var db *gorm.DB

if PsqlConnInfo.Schema == "" {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if PsqlConnInfo.Schema == "" {
if PsqlConnInfo.Schema == "" {
glog.V(2).Info("No schema set.")

@chen-keinan
Copy link
Copy Markdown
Contributor

@luis-serra-ki thank you for the contribution , added a couple of comments

@mozillazg
Copy link
Copy Markdown
Contributor

@serrovsky-pt Could you please take a look at these new comments? Thanks!

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mozillazg
✅ serrovsky
❌ luisserra


luisserra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants