Skip to content

Make Geant4 a strict dependency#528

Merged
agheata merged 1 commit intoapt-sim:masterfrom
SeverinDiederichs:require_G4_in_cmake
Mar 29, 2026
Merged

Make Geant4 a strict dependency#528
agheata merged 1 commit intoapt-sim:masterfrom
SeverinDiederichs:require_G4_in_cmake

Conversation

@SeverinDiederichs
Copy link
Copy Markdown
Collaborator

@SeverinDiederichs SeverinDiederichs commented Mar 27, 2026

Geant4 was not required in some standalone examples in AdePT, which don't exist anymore.

Therefore, Geant4 is required now, and now this is enforced correctly in CMake

It was verified that this PR

  • Changes physics results
  • Does not change physics results

@SeverinDiederichs SeverinDiederichs added CI Category: related to the continuous integration cleaning improves code clarity, readability or other labels Mar 27, 2026
@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@SeverinDiederichs SeverinDiederichs changed the title require Geant4 for AdePT Make Geant4 a strict dependency Mar 27, 2026
@SeverinDiederichs SeverinDiederichs added build Category: Build system related issue. and removed CI Category: related to the continuous integration labels Mar 27, 2026
Copy link
Copy Markdown
Contributor

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@agheata agheata merged commit 4032a7b into apt-sim:master Mar 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Category: Build system related issue. cleaning improves code clarity, readability or other

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants