deps: bump github.com/apstndb/spanvalue from v0.5.0 to v0.7.5#42
Merged
Conversation
No code changes needed: execspansql uses only the spanvalue/writer CSV path (NewCSVWriter, WriteRowIterator, WriteStructValues, WriteRow, PrepareRowType), and the Simple preset CSV output is unchanged across v0.5.0..v0.7.5, so all golden and contract tests pass without regold. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates several Go dependencies in go.mod and go.sum, including OpenTelemetry libraries, spanvalue, go-jose, testify, go-internal, and golang.org/x/sys. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/apstndb/spanvaluefrom v0.5.0 to v0.7.5 (current release), with transitive updates picked up bygo mod tidy(go-jose, testify, OpenTelemetry v1.40.0, golang.org/x/sys).spanvalue/writerCSV path (NewCSVWriter,WriteRowIterator,WriteStructValues,WriteRow,PrepareRowType,Flush) with the default Simple preset, whose CSV output is unchanged across this range.csv_golden_test.goand the spanvalue contract tests (csv_test.go) pass unchanged.Behavior-change review (v0.5.0 → v0.7.5 release notes)
FormatConfiggained an exported nested field; unkeyed composite literals breakFormatConfig; it only uses writer defaults (Simple preset)NewSQLInsertWriter(out, "")errors at constructionFormatNullableslow path returns error instead of panicFormatConfig/FormatNullablego.modalready declaresgo 1.24.0WithComplexPluginprepends1.000000→1; Literal integral FLOAT64 gains.0TimestampValueUTC normalizationErrInvalidSQLInsertKind; GoogleSQLQuoteIdentifierescaping fixTest plan
go build ./.../go vet ./...go test ./...— all packages pass, includingTestExperimentalCsvSpanvalueContract(execspansql CSV vs spanvalueDelimitedWriter),TestExperimentalCsvGolden(goldens unchanged, no-update-goldenneeded), and CSV fixture testsgo test -v -run TestWithCloudSpannerEmulator .— emulator integration test ran via testcontainers/Docker and passed (verified it did not silently skip)golangci-lint run— one pre-existingstaticcheckQF1002 finding atmain.go:549, also present onmain; not introduced by this PR🤖 Generated with Claude Code