Skip to content

deps: bump github.com/apstndb/spanvalue from v0.5.0 to v0.7.5#42

Merged
apstndb merged 1 commit into
mainfrom
bump/spanvalue-v0.7.5
Jun 11, 2026
Merged

deps: bump github.com/apstndb/spanvalue from v0.5.0 to v0.7.5#42
apstndb merged 1 commit into
mainfrom
bump/spanvalue-v0.7.5

Conversation

@apstndb

@apstndb apstndb commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Bump github.com/apstndb/spanvalue from v0.5.0 to v0.7.5 (current release), with transitive updates picked up by go mod tidy (go-jose, testify, OpenTelemetry v1.40.0, golang.org/x/sys).
  • No source changes required: execspansql uses only the spanvalue/writer CSV path (NewCSVWriter, WriteRowIterator, WriteStructValues, WriteRow, PrepareRowType, Flush) with the default Simple preset, whose CSV output is unchanged across this range.
  • No golden regold needed: csv_golden_test.go and the spanvalue contract tests (csv_test.go) pass unchanged.

Behavior-change review (v0.5.0 → v0.7.5 release notes)

Release Change Affects execspansql?
v0.5.1 FormatConfig gained an exported nested field; unkeyed composite literals break No — execspansql never hand-builds FormatConfig; it only uses writer defaults (Simple preset)
v0.6.0 NewSQLInsertWriter(out, "") errors at construction No — SQL INSERT export is not used
v0.6.0 nil-FormatNullable slow path returns error instead of panic No — no custom FormatConfig / FormatNullable
v0.7.0 Minimum Go 1.24 No impact — go.mod already declares go 1.24.0
v0.7.0 Literal preset NaN/±Inf CAST quoting; WithComplexPlugin prepends No — Literal preset and plugins not used
v0.7.1 Spanner CLI preset integral floats 1.0000001; Literal integral FLOAT64 gains .0 No — only Simple preset (CSV) is used; Simple output unchanged
v0.7.1 gcvctor TimestampValue UTC normalization No — gcvctor not used
v0.7.1 JSON wire emitted without HTML escapes No — JSON output in execspansql goes through go-jq-yamlformat, not spanvalue
v0.7.5 Writer sticky errors; whole-statement SQL INSERT emission; ErrInvalidSQLInsertKind; GoogleSQL QuoteIdentifier escaping fix No behavioral impact — SQL INSERT not used; CSV writers are already discarded on error, so sticky errors only harden existing usage

Test plan

  • go build ./... / go vet ./...
  • go test ./... — all packages pass, including TestExperimentalCsvSpanvalueContract (execspansql CSV vs spanvalue DelimitedWriter), TestExperimentalCsvGolden (goldens unchanged, no -update-golden needed), and CSV fixture tests
  • go test -v -run TestWithCloudSpannerEmulator . — emulator integration test ran via testcontainers/Docker and passed (verified it did not silently skip)
  • golangci-lint run — one pre-existing staticcheck QF1002 finding at main.go:549, also present on main; not introduced by this PR

🤖 Generated with Claude Code

No code changes needed: execspansql uses only the spanvalue/writer
CSV path (NewCSVWriter, WriteRowIterator, WriteStructValues, WriteRow,
PrepareRowType), and the Simple preset CSV output is unchanged across
v0.5.0..v0.7.5, so all golden and contract tests pass without regold.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Go dependencies in go.mod and go.sum, including OpenTelemetry libraries, spanvalue, go-jose, testify, go-internal, and golang.org/x/sys. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@apstndb apstndb merged commit bdbd071 into main Jun 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant