Report Appwrite MCP server metadata#79
Conversation
Greptile SummaryThis PR reports Appwrite MCP server metadata (package version, website URL, and icon) during initialization by passing new keyword arguments to the low-level
Confidence Score: 4/5The core logic change is minimal and the new test directly exercises the metadata path; the one concern is whether the mcp lower bound covers the version that introduced these constructor params. The change to build_mcp_server is straightforward and the new test is thorough. The lower bound >=1.12.0 stays unchanged while the new website_url and icons keyword arguments to the low-level Server constructor only appear documented from mcp 1.19.0 onward — any environment resolving to an older 1.x release could encounter a TypeError at startup. pyproject.toml — the mcp lower bound likely needs a bump to align with when website_url/icons were added to the low-level Server class. Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
pyproject.toml:11
**Minimum version may not support `website_url`/`icons` on the low-level `Server`**
The lock file resolves to mcp 1.28.0, but the lower bound stays at `>=1.12.0`. The icons/website_url documentation first appears in the mcp 1.19.0 release. Any fresh install that resolves to exactly 1.12.0 through ~1.18.x could fail with `TypeError: unexpected keyword argument` when `build_mcp_server` tries to construct `Server(..., website_url=..., icons=...)`. The lower bound should be bumped to the earliest version that added these parameters to the low-level `Server` class (likely `>=1.19.0` based on available evidence).
Reviews (1): Last reviewed commit: "(fix): report Appwrite MCP server metada..." | Re-trigger Greptile |
| "appwrite>=21.0.0,<22", | ||
| "docstring-parser>=0.16", | ||
| "mcp[cli]>=1.12.0", | ||
| "mcp[cli]>=1.12.0,<2", |
There was a problem hiding this comment.
Minimum version may not support
website_url/icons on the low-level Server
The lock file resolves to mcp 1.28.0, but the lower bound stays at >=1.12.0. The icons/website_url documentation first appears in the mcp 1.19.0 release. Any fresh install that resolves to exactly 1.12.0 through ~1.18.x could fail with TypeError: unexpected keyword argument when build_mcp_server tries to construct Server(..., website_url=..., icons=...). The lower bound should be bumped to the earliest version that added these parameters to the low-level Server class (likely >=1.19.0 based on available evidence).
Prompt To Fix With AI
This is a comment left during a code review.
Path: pyproject.toml
Line: 11
Comment:
**Minimum version may not support `website_url`/`icons` on the low-level `Server`**
The lock file resolves to mcp 1.28.0, but the lower bound stays at `>=1.12.0`. The icons/website_url documentation first appears in the mcp 1.19.0 release. Any fresh install that resolves to exactly 1.12.0 through ~1.18.x could fail with `TypeError: unexpected keyword argument` when `build_mcp_server` tries to construct `Server(..., website_url=..., icons=...)`. The lower bound should be bumped to the earliest version that added these parameters to the low-level `Server` class (likely `>=1.19.0` based on available evidence).
How can I resolve this? If you propose a fix, please make it concise.
Summary
Testing
uv run --group dev ruff check src testsuv run --group dev black --check src testsuv run --group dev pyrightuv run python -m unittest discover -s tests/unit -vdocker build -t appwrite-mcp:ci .Related issue
N/A