Skip to content

fix(databases): correct enum icon and hide indexed checkbox for relationships #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 2 commits into from
Jul 10, 2026
+29 −20
Merged

fix(databases): correct enum icon and hide indexed checkbox for relationships #3114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca5f703
fix(databases): correct enum icon and hide indexed checkbox for relat…
HarshMN2345 Jul 10, 2026
8f67efb
fix(databases): treat empty format as no format in enum icon lookup
HarshMN2345 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ect-[region]-[project]/databases/database-[database]/(entity)/views/indexes/create.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@
.map((field) => ({
value: field.key,
label: field.key,
leadingIcon: baseColumnOptions.find((option) => option.type === field.type)?.icon
leadingIcon: baseColumnOptions.find(
(option) =>
option.type === field.type &&
option.format ===
('format' in field && field.format ? field.format : undefined)
)?.icon
}))
);

Expand Down
42 changes: 23 additions & 19 deletions ...oject-[region]-[project]/databases/database-[database]/table-[table]/columns/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,26 +515,30 @@
{columnType.toLowerCase()}
</Spreadsheet.Cell>
<Spreadsheet.Cell column="indexed" {root} isEditable={false}>
<!-- $id is always indexed internally -->
{@const isActuallyIndexed =
isId || $indexes.some((index) => index.columns.includes(column.key))}

<!-- $id is always indexed internally -->
{@const checked = isId || isActuallyIndexed || !!columnIndexMap[column.key]}

<Selector.Checkbox
size="s"
{checked}
disabled={isActuallyIndexed}
on:change={(e) => {
if (!isActuallyIndexed) {
if (e.detail) {
columnIndexMap[column.key] = true;
$showCreateIndexSheet.show = true;
$showCreateIndexSheet.column = column.key;
{#if !isRelationship(column)}
<!-- $id is always indexed internally -->
{@const isActuallyIndexed =
isId ||
$indexes.some((index) => index.columns.includes(column.key))}

<!-- $id is always indexed internally -->
{@const checked =
isId || isActuallyIndexed || !!columnIndexMap[column.key]}

<Selector.Checkbox
size="s"
{checked}
disabled={isActuallyIndexed}
on:change={(e) => {
if (!isActuallyIndexed) {
if (e.detail) {
columnIndexMap[column.key] = true;
$showCreateIndexSheet.show = true;
$showCreateIndexSheet.column = column.key;
}
}
}
}} />
}} />
{/if}
</Spreadsheet.Cell>
<Spreadsheet.Cell column="default" {root} isEditable={false}>
{@const _default = column.required
Expand Down