Propagate existing attempt IDs into Q&A retrieval path (issue/short_id fallback, no attempt creation)#124
Draft
ArnabChatterjee20k with Copilot wants to merge 1 commit into
Draft
Propagate existing attempt IDs into Q&A retrieval path (issue/short_id fallback, no attempt creation)#124ArnabChatterjee20k with Copilot wants to merge 1 commit into
ArnabChatterjee20k with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix Q&A retrieval usage persistence and logging
Propagate existing attempt IDs into Q&A retrieval path (issue/short_id fallback, no attempt creation)
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q&A runs were bypassing retrieval usage persistence because
attempt_idcould beNoneon the question path; as a result,retrieval_usagerows were skipped andlog_retrieval_recorded()never emitted. This change ensures Q&A uses an existing attempt ID when available (issue-id first, short-id fallback) without synthesizing new attempts.Attempt ID resolution centralized before Q&A routing
effective_attempt_idonce per processor run:input.attempt_idtracker.get_attempt(source, issue_id)tracker.get_attempt_by_short_id(source, short_id)effective_attempt_idtoanswer_question_issue(...)and reuse consistently in retrieval-recording paths.Tracker API extension for short-id recovery
FixAttemptTrackerfor(source, short_id)to recover pre-existing attempts when issue-id lookup misses.DISCORD-15265329) resolve to the original attempt.No synthetic attempts
Targeted observability
attempt_idattempt_idsource (issue_id vs short_id)