fix: prevent table menu button clipping#41944
Conversation
WalkthroughUpdates the TableWidgetV2 menu button to use full-width, border-box sizing and adds a Cypress check that confirms the button fits within its cell in deployed mode. ChangesMenu Button Cell-Fit Fix
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/ColumnTypeMenubutton_spec.js`:
- Line 9: The Cypress selector in the ColumnTypeMenubutton_spec test is tied to
Blueprint’s internal .bp3-button class, so update the cy.get lookup to use an
existing data-* attribute on the button instead. Keep the test aligned with the
codebase convention by selecting through a stable data selector in the relevant
TableV2 column type interaction, and avoid plain class-based CSS selectors here.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 15da5c33-e72b-4647-8f82-a6c5443c054c
📒 Files selected for processing (2)
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/ColumnTypeMenubutton_spec.jsapp/client/src/widgets/TableWidgetV2/component/cellComponents/menuButtonTableComponent.tsx
Description
Fixes #41578
Prevents Table V2 menu buttons from overflowing their cell box in published apps. The button now uses a border-box width so padding and borders stay inside the cell instead of being clipped by the table cell overflow.
Also adds a Cypress regression check that deploys the app and verifies the menu button remains within the published table cell bounds.
Validation
git diff --checknode_modulesstate file, and available local Node versions are24.11.1and24.14.0while the project requires^24.14.1.Summary by CodeRabbit
Bug Fixes
Tests