Skip to content

Avoid building pyrobuf extensions during metadata#165

Open
rlopezquadient wants to merge 2 commits into
appnexus:masterfrom
rlopezquadient:fix/metadata-build
Open

Avoid building pyrobuf extensions during metadata#165
rlopezquadient wants to merge 2 commits into
appnexus:masterfrom
rlopezquadient:fix/metadata-build

Conversation

@rlopezquadient
Copy link
Copy Markdown

This fixes source installs of pyrobuf with modern setuptools / pip build isolation.

Root cause :
During metadata generation, setup.py was triggering builtin extension generation too early through the custom Distribution flow. That caused setuptools metadata preparation to execute build-time side effects, and source installs failed with:

AttributeError: 'PyrobufDistribution' object has no attribute 'dry_run'

@juntyr
Copy link
Copy Markdown

juntyr commented Mar 25, 2026

An alternative and much simpler fix is to add a constraint to setup_requires that bounds setuptools < 81

@Kevin-Prichard
Copy link
Copy Markdown

This fixes source installs of pyrobuf with modern setuptools / pip build isolation.
...
An alternative and much simpler fix is to add a constraint to setup_requires that bounds setuptools < 81

Either way it's happening in the wild, with users experiencing this breakage on pip install pyrobuf and its dependents, e.g. PyrOSM.

Please choose a fix and release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants