Track pending wakeup state in Timer#29
Open
glbrntt wants to merge 1 commit into
Open
Conversation
Timer's optimisation in 'recalculate' for an already scheduled wakeup applies even if there's no wakeup pending. This can happen when the wakeup is early as an event which would've fallen within the threshold no longer does, so it can remain unscheduled. Store the kernel wakeup state as an enum: it's either armed for a given time or idle.
glbrntt
requested review from
agnosticdev,
kkuk24,
rpaulo and
tfpauly
as code owners
tfpauly
reviewed
Jun 19, 2026
| return .zero | ||
| } | ||
| } | ||
| private var wakeup: KernelWakeup = .idle |
Collaborator
There was a problem hiding this comment.
Does it make sense to call this "kernel" always? Maybe some other term to indicate it is the actual lower state?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timer's optimisation in 'recalculate' for an already scheduled wakeup applies even if there's no wakeup pending. This can happen when the wakeup is early as an event which would've fallen within the threshold no longer does, so it can remain unscheduled.
Store the kernel wakeup state as an enum: it's either armed for a given time or idle.