Fix pow with a constant base of 2 squaring the exponent#2742
Open
eyupcanakman wants to merge 1 commit into
Open
Fix pow with a constant base of 2 squaring the exponent#2742eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
The behavior matches a pow(x, 2) square fast path in the Core ML runtime keyed on a constant operand of 2 regardless of side, so a constant base of 2 returns the exponent squared. A new backend pass rewrites pow(2, y) into exp(y * log(2)), which avoids the constant-2 base and is computed correctly. Fixes apple#2628.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pow(x, y)with a constant base of 2 returnsy ** 2instead of2 ** y. Only an exact constant base of 2 is affected. Other bases, and a constant exponent of 2 (pow(x, 2)), are computed correctly. The behavior matches apow(_, 2)square fast path in the runtime that keys on a constant operand of 2 regardless of which side it is on.decompose_const_base2_powrewritespow(2, y)intoexp(y * log(2)), which is equal and avoids the constant-2 base. It runs in the backend pipeline, so it applies to every frontend and tomilinternalinput. Floating-point pow only.test_decompose_predict_valuesconvertspow(2, y)and checks the predicted output against2 ** yin fp32 and fp16. It fails on main without the fix.Fixes #2628.