Fix build.sh num-procs help text#2699
Merged
Merged
Conversation
The --help output documented the option as --num_procs but the parser only accepts --num-procs (build.sh:53). Update the help text to match the accepted spelling so users following --help don't hit "Unknown option". Refs apple#2376
TobyRoseman
approved these changes
May 18, 2026
Collaborator
|
Thanks for the contribution @LeSingh1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/build.sh --helpdocuments the option as--num_procs, but the argument parser only accepts--num-procs(seescripts/build.sh:53). A user copy-pasting from--helphits theunknown_optionbranch and the script exits.This corrects the documented spelling to match the accepted spelling. One-character change.
Refs #2376 (build-script item 1).
Test plan
bash -n scripts/build.sh— syntax OKbash scripts/build.sh --help— now prints--num-procs=n (default 1)grep "num_procs\|num-procs" scripts/build.sh— both lines now use--num-procsScope
Intentionally narrow. This PR does not modernize CMake, change NumPy pins, refactor Python detection, or touch any other item from #2376 — those need separate discussion.