-
Notifications
You must be signed in to change notification settings - Fork 275
Write file data in chunks in ContentWriter #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 119 additions & 0 deletions
119
Tests/ContainerizationOCITests/ContentWriterTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // Copyright © 2026 Apple Inc. and the Containerization project authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import ContainerizationError | ||
| import Crypto | ||
| import Foundation | ||
| import Testing | ||
|
|
||
| @testable import ContainerizationOCI | ||
|
|
||
| @Suite("ContentWriter Tests") | ||
| struct ContentWriterTests { | ||
| private func withTempDirectory(_ body: (URL) throws -> Void) throws { | ||
| let dir = FileManager.default.temporaryDirectory | ||
| .appendingPathComponent(UUID().uuidString) | ||
| try FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true) | ||
| defer { try? FileManager.default.removeItem(at: dir) } | ||
| try body(dir) | ||
| } | ||
|
|
||
| private func makeTempFile(in dir: URL, data: Data) throws -> URL { | ||
| let url = dir.appendingPathComponent(UUID().uuidString) | ||
| try data.write(to: url) | ||
| return url | ||
| } | ||
|
|
||
| @Test func testWriteReturnsCorrectSizeAndDigest() throws { | ||
| try withTempDirectory { dir in | ||
| let writer = try ContentWriter(for: dir) | ||
| let data = Data("test content".utf8) | ||
| let (size, digest) = try writer.write(data) | ||
| let expected = SHA256.hash(data: data) | ||
| let destination = dir.appendingPathComponent(digest.encoded) | ||
| #expect(size == Int64(data.count)) | ||
| #expect(digest == expected) | ||
| #expect(FileManager.default.fileExists(atPath: destination.path)) | ||
| } | ||
| } | ||
|
|
||
| @Test func testWriteDuplicateData() throws { | ||
| try withTempDirectory { dir in | ||
| let writer = try ContentWriter(for: dir) | ||
| let data = Data("duplicate".utf8) | ||
| #expect(throws: Never.self) { | ||
| try writer.write(data) | ||
| try writer.write(data) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test func testCreateFromFileSmallFile() throws { | ||
| try withTempDirectory { base in | ||
| try withTempDirectory { src in | ||
| let data = Data("small file contents".utf8) | ||
| let sourceURL = try makeTempFile(in: src, data: data) | ||
| let writer = try ContentWriter(for: base) | ||
| let (size, digest) = try writer.create(from: sourceURL) | ||
| let destination = base.appendingPathComponent(digest.encoded) | ||
| let written = try Data(contentsOf: destination) | ||
| #expect(size == Int64(data.count)) | ||
| #expect(digest == SHA256.hash(data: data)) | ||
| #expect(FileManager.default.fileExists(atPath: destination.path)) | ||
| #expect(written == data) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test func testCreateFromFileLargeFileDuplicates() throws { | ||
| try withTempDirectory { base in | ||
| try withTempDirectory { src in | ||
| let count = 3 * 1024 * 1024 + 100 | ||
| var bytes = [UInt8](repeating: 0, count: count) | ||
| arc4random_buf(&bytes, count) | ||
| let data = Data(bytes) | ||
| let sourceURL = try makeTempFile(in: src, data: data) | ||
| let writer = try ContentWriter(for: base) | ||
| let (size, digest) = try writer.create(from: sourceURL) | ||
| let destination = base.appendingPathComponent(digest.encoded) | ||
| #expect(size == Int64(data.count)) | ||
| #expect(digest == SHA256.hash(data: data)) | ||
| #expect(throws: Never.self) { | ||
| try writer.create(from: sourceURL) | ||
| } | ||
| #expect(FileManager.default.fileExists(atPath: destination.path)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private struct SamplePayload: Codable, Equatable { | ||
| let name: String | ||
| let value: Int | ||
| } | ||
|
|
||
| @Test func testCreateFromEncodableReturnsCorrectDigest() throws { | ||
| try withTempDirectory { base in | ||
| let writer = try ContentWriter(for: base) | ||
| let payload = SamplePayload(name: "digest-check", value: 99) | ||
| let (size, digest) = try writer.create(from: payload) | ||
| let encoder = JSONEncoder() | ||
| encoder.outputFormatting = [.sortedKeys] | ||
| let expected = try encoder.encode(payload) | ||
| #expect(size == Int64(expected.count)) | ||
| #expect(digest == SHA256.hash(data: expected)) | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.