Add progress handler for rootfs unpacking#515
Open
DePasqualeOrg wants to merge 13 commits intoapple:mainfrom
Open
Add progress handler for rootfs unpacking#515DePasqualeOrg wants to merge 13 commits intoapple:mainfrom
DePasqualeOrg wants to merge 13 commits intoapple:mainfrom
Conversation
DePasqualeOrg
force-pushed
the
unpacking-progress
branch
from
29d543a to
fed09a0
Compare
dkovba
reviewed
Mar 11, 2026
Contributor
dkovba
left a comment
dkovba
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
DePasqualeOrg
force-pushed
the
unpacking-progress
branch
from
9330cca to
1072ce0
Compare
dkovba
reviewed
Mar 12, 2026
Contributor
|
@DePasqualeOrg Please run |
dkovba
reviewed
Mar 13, 2026
Tests/ContainerizationTests/ImageTests/HeaderScanTimingTests.swift
Outdated
Show resolved
Hide resolved
- Use Int for item counts - Restore Task.checkCancellation() in layer resolution loop - Use a single shared temp directory for layer archives in tests - Replace force-unwrapped URL with a default value in timing tests
dkovba
reviewed
Mar 14, 2026
| try Task.checkCancellation() | ||
| guard entry.path != nil else { continue } | ||
| totalItems += 1 | ||
| if entry.fileType == .regular, let size = entry.size { |
Contributor
There was a problem hiding this comment.
Suggested change
| if entry.fileType == .regular, let size = entry.size { | |
| if entry.fileType == .regular, entry.hardlink == nil, let size = entry.size { |
Contributor
There was a problem hiding this comment.
It seems we don't emit add-size events for hard links, and shouldn't count them in the total size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an optional progress handler for rootfs unpacking so that consumers can show progress. The Ubuntu image takes about 8 seconds to unpack on my machine, and I'm developing an app where it would be useful to show progress in the UI.
Total size is determined in an optional first pass that scans archive headers. Bytes written are then reported during unpacking. The optional first pass adds 15 (Alpine) to 115 (Ubuntu) ms to unpacking duration on my machine, depending on image size.