[keychain]: add functions for container registry list command #502
Conversation
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
@saehejkang a couple suggestions so that it fits better with the managed resource plan. I've been swamped with other things and need time to think through the design a bit further for that, but we will get there soon.
| } | ||
|
|
||
| /// List all registry domains this id has credentials for. | ||
| public func listDomains() throws -> [String] { |
There was a problem hiding this comment.
Let's nudge this towards something where a registry can be a managed resource in container.
The caller is presumably the manager of a specific keychain domain (such as the one for container).
I think this should be a list(domain:) -> [RegistryInfo] that enumerates all keychain entries for the domain, mapping them to a new structure that has all the stored attributes for the registry except the secret value.
This structure should conform to Sendable but not Codable - the client is responsible for that. In container it will be that it eventually conforms to managed resource but could just be RegistryInfo with a Codable extension initially.
Thoughts?
| } | ||
|
|
||
| /// List all hostnames in the keychain. | ||
| public func listHosts(id: String) throws -> [String] { |
There was a problem hiding this comment.
Do we need a public version of two calls if we implement the suggestion above?
2 participants
Changes Made
container registry listcommandRelates to: apple/container#1088