Skip to content

vminitd: Set nofile rlimit to max #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcantah merged 1 commit into from
Jan 29, 2026
+8 −8
Merged

vminitd: Set nofile rlimit to max #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions vminitd/Sources/vminitd/InitCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ struct InitCommand {

static func run(log: Logger) async throws {
var log = log

try Self.adjustLimits()
try Self.adjustLimits(log)

// when running under debug mode, launch vminitd as a sub process of pid1
// so that we get a chance to collect better logs and errors before pid1 exists
Expand Down Expand Up @@ -170,13 +169,14 @@ struct InitCommand {
log.info("child process exited with code: \(exitCode)")
}

private static func adjustLimits() throws {
var limits = rlimit()
guard getrlimit(RLIMIT_NOFILE, &limits) == 0 else {
throw POSIXError(.init(rawValue: errno)!)
private static func adjustLimits(_ log: Logger) throws {
let nrOpen = try String(contentsOfFile: "/proc/sys/fs/nr_open", encoding: .utf8)
.trimmingCharacters(in: .whitespacesAndNewlines)
guard let max = rlim_t(nrOpen) else {
throw POSIXError(.EINVAL)
}
limits.rlim_cur = 65536
limits.rlim_max = 65536
log.debug("setting RLIMIT_NOFILE to \(max)")
var limits = rlimit(rlim_cur: max, rlim_max: max)
guard setrlimit(RLIMIT_NOFILE, &limits) == 0 else {
throw POSIXError(.init(rawValue: errno)!)
}
Expand Down