Log graceful-stop errors instead of silently swallowing them#1777
Open
LynxBay wants to merge 1 commit into
Open
Log graceful-stop errors instead of silently swallowing them#1777LynxBay wants to merge 1 commit into
LynxBay wants to merge 1 commit into
Conversation
gracefulStopContainer wrapped its signal/timeout/kill logic in an empty catch {}, discarding any failure (for example, failing to obtain an exit code). The vm is still powered off afterwards, but the swallowed error left graceful-stop failures with no trace.
Log the error so failures are observable, matching the existing error logging in cleanUpContainer in the same file.
Closes apple#1756
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gracefulStopContainerwrapped its signal/timeout/kill logic in an emptycatch {}, silently discarding any failure that occurred while attempting a graceful stop (for example, failing to obtain the container's exit code). The vm is still powered off on the next line, so the error is not fatal — but the swallowed error left graceful-stop failures with no trace in the logs, making them impossible to diagnose.Fixes #1756.
Change
Replace the empty
catch {}inSources/Services/RuntimeLinux/Server/RuntimeService.swiftwith an error log, matching the error logging already used bycleanUpContainerin the same file:Control flow is otherwise unchanged: the caught error remains non-fatal and the vm is still powered off. The only behavioral change is that the error is now observable.
Verification
swift build --target ContainerRuntimeLinuxServer— builds clean (RuntimeService.swiftcompiles).🤖 Generated with Claude Code