Add insecure registry configuration for pull/push/login#1768
Open
muk2 wants to merge 1 commit into
Open
Conversation
Adds an `insecureRegistries` list to the `[registry]` section of config.toml. Hosts listed there are accessed over plain-text HTTP when the request scheme is left at the default `auto`, without requiring `--scheme http` on every command. An explicit `--scheme http`/`--scheme https` continues to take precedence. The list is empty by default, so insecure access is strictly opt-in per host. Fixes apple#731
9a99125 to
6f58ca4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
insecureRegistrieslist to the[registry]section of the systemconfiguration. Hosts listed there are accessed over plain-text HTTP when the
request scheme is left at the default
auto, without requiring--scheme httpon every
pull/push/logincommand. This mirrors the "insecure registries"capability in other container tooling and addresses #731.
Behavior:
host[:port].--scheme http/--scheme httpsalways takes precedence over the list.ClientImage) andregistry login(RegistryLogin).Example
config.toml:Scope
This implements plain-HTTP access for listed registries. It does not change
TLS certificate verification for HTTPS registries (i.e. it is not a
"skip-cert-verification" toggle). Self-signed-HTTPS support could be a follow-up.
Testing
make check— formatting and license headers pass.make test): addedRequestSchemeTestsandConfigurationLoaderTestscoverage (31 tests) for host matching, case-insensitivity,
host:porthandling,explicit-scheme precedence, and TOML decode/default. All pass.
hostname so the new code path is actually exercised (private IPs/localhost are
already treated as insecure):
insecureRegistries→ fails (auto→ HTTPS against an HTTPregistry).
in
image ls.--scheme httpswith the host listedstill fails — confirming explicit scheme overrides the list.
Docs
Updated
docs/container-system-config.mdwith the new field and a security note.Fixes #731