fix(logs): resolve SwiftLog handler deprecation warnings for https://github.com/apple/container/issues/1754#1758
Open
stephenlclarke wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes #1754.
Downstream packages can resolve a newer SwiftLog than this repository's current lockfile. In
container-compose, SwiftLog1.13.2emits deprecation warnings because the customContainerLoghandlers rely on SwiftLog's deprecated default bridge forlog(event:).This PR keeps the change split into two reviewable commits:
09f2e5cchore: update swift-log lockfile4a2699bfix(logs): implement SwiftLog event handlersThe first commit updates SwiftLog from
1.10.1to1.13.2. The second commit adds explicitlog(event:)implementations forFileLogHandler,OSLogHandler, andStderrLogHandler.The existing output formatting is preserved by routing both logging entry points through private helpers. The lockfile update is required because
LogEventis not available in SwiftLog1.10.1.Testing
Local validation:
swift build --disable-automatic-resolution --target ContainerLog/tmp/container-log-build.logfordeprecated default implementation,DeprecatedDeclaration, andwarning:; no matchesgit diff --check origin/main..HEAD