fix: handle launchctl bootout permission errors in ensure-container-stopped.sh#1306
Open
Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Open
fix: handle launchctl bootout permission errors in ensure-container-stopped.sh#1306Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Ronitsabhaya75 wants to merge 1 commit intoapple:mainfrom
Conversation
…topped.sh Co-authored-by: Renish Avaiya <renishpatel2482001@gmail.com> Co-authored-by: Shilpan Shah <Shilpan97@gmail.com>
Ronitsabhaya75
force-pushed
the
issue-1281
branch
from
0219e17 to
53e4cd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
fixes #1281
Right now, running brew install container fails with "Operation not permitted" because the post-install script tries to stop system domain services, which requires root access.
The Fix: Updated the script to skip the system domain when not running as root, and strictly ignore bootout errors so they don't crash the installation.
added them as co authored, tested by: @Renish-patel, @shilpan97
Testing