Add TCP DNS transport with connection limits, idle timeout, and frame guard (To-Do)#1272
Open
Ronitsabhaya75 wants to merge 11 commits intoapple:mainfrom
Open
Add TCP DNS transport with connection limits, idle timeout, and frame guard (To-Do)#1272Ronitsabhaya75 wants to merge 11 commits intoapple:mainfrom
Ronitsabhaya75 wants to merge 11 commits intoapple:mainfrom
Conversation
Co-authored-by: Rodrigo Munoz <rodrigo.munoz.cs@gmail.com> # Conflicts: # Sources/Helpers/APIServer/APIServer+Start.swift
16fc5cb to
4afa87b
Compare
Contributor
Author
|
Co-authored-by: renish avaiya <renishpatel2482001@gmail.com>
178d000 to
47c831a
Compare
4e64e1f to
1e28420
Compare
|
Hey @jglogan, could you take a look at this TCP implementation when you get a chance? It’s been on to‑do list for a long time, and I think it’ll be a solid improvement for the network going forward. |
vikashftw
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Right now, our DNS server only handles UDP. Since UDP has a 512-byte limit, any large responses (like when resolving a bunch of container names) just get silently cut off. The standard way to handle this is for clients to retry over TCP when they see a truncated response.
The Fix: I've added a TCP listener that runs alongside the UDP server on the same port, handling queries that need more space.
Key changes:
processRaw(data:)so both UDP and TCP share the exact same query logic.Testing