fix: read the changelog from an artifact in the Python release workflow - #312
Merged
Conversation
vdusek
added
adhoc
vdusek
marked this pull request as ready for review
August 17, 2026 08:00
janbuchar
approved these changes
Aug 17, 2026
janbuchar
left a comment
janbuchar
left a comment
Contributor
There was a problem hiding this comment.
There is a lot of fluff for such a simple change, but I won't stall the PR because of that.
Contributor
Author
It's because of keeping the old way working as well. A lot of repos, and not just ours, use this workflow, if I'm not mistaken (integrations, AI), and I don't know whether they are using exact version pinning. We could mark this as a breaking change and release 1.x. That would also be correct from a semantic-versioning perspective. But I'd rather stay conservative here and keep it backward compatible. |
vdusek
pushed a commit
that referenced
this pull request
Aug 17, 2026
🤖 I have created a release *beep* *boop* --- ## [0.48.1](v0.48.0...v0.48.1) (2026-08-17) ### Bug Fixes * read the changelog from an artifact in the Python release workflow ([#312](#312)) ([92607e6](92607e6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vdusek
added a commit
to apify/crawlee-python
that referenced
this pull request
Aug 17, 2026
Every beta and stable release has failed since 2026-08-17, at the `Update CHANGELOG.md` step, with no code change involved: ``` An error occurred trying to start process '.../node' ... Argument list too long ``` `CHANGELOG.md` crossed 128 KiB. The changelog was passed to the release workflow as a string input, the workflow handed it to an action via `with: contents:`, and the runner passes action inputs as environment variables - Linux caps a single environment string at `MAX_ARG_STRLEN` (32 pages = 131072 bytes). The generated changelog measured 131,410 bytes; the last green release squeezed in about 140 bytes under the limit. Both release workflows now hand the changelog over as an artifact, which has no size limit: apify/actions#36 uploads it, apify/workflows#312 downloads it. Blocked until apify/actions is released as v1.5.0, which is what the bumped pin refers to. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Update CHANGELOG.mdstep handedinputs.changelogtoDamianReeves/write-file-actionviawith: contents:. The runner passes action inputs as environment variables, and Linux caps a single environment string atMAX_ARG_STRLEN(32 pages = 131072 bytes), so the step never starts once the changelog crosses ~128 KiB:That broke every crawlee-python beta and stable release from 2026-08-17 on, at 131,410 bytes of generated changelog and with no code change involved.
The changelog now travels as an artifact instead.
apify/actions/git-cliff-releaseuploads it (apify/actions#36) and this workflow downloads it and moves it into place - no size limit, and a same-run download needs no extra token permission.Backwards compatible: the
changeloginput stays as a deprecated fallback for callers still pinned togit-cliff-release@v1.4.0, which does not upload the artifact. Drop the input and the fallback step once every caller is bumped. Since the input is now optional, a separate step fails the job when neither source carries a changelog, rather than silently truncatingCHANGELOG.mdand committing it.Two new optional inputs:
changelog_artifact_nameandchangelog_path.Merge order: apify/actions#36 must be released as v1.5.0 before callers can pin it. This workflow is referenced as
@main, so it takes effect for all callers immediately - hence the fallback.✍️ Drafted by Claude Code