fix(playwright): dispose of APIResponse body for send_request#1771
Open
kozlice wants to merge 2 commits intoapify:masterfrom
Open
fix(playwright): dispose of APIResponse body for send_request#1771kozlice wants to merge 2 commits intoapify:masterfrom
APIResponse body for send_request#1771kozlice wants to merge 2 commits intoapify:masterfrom
Conversation
Dispose of Playwright's APIResponse body, otherwise it stays in memory until the context closes. If not done, this can lead to excessive memory usage during crawling when using `send_request` within a handler.
kozlice
changed the title
APIResponse body for send_request
vdusek
approved these changes
Mar 2, 2026
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Thanks, looks good, I have just one nit.
Collaborator
|
@Mantisus Could you please check this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dispose of Playwright's APIResponse body, otherwise it stays in memory until the context closes.
If not done, this can lead to excessive memory usage during crawling when using
send_requestwithin a handler.Issues
...
Testing
send_requestis already covered by tests, so if they pass I think it should be OK.Checklist