ci: dispatch beta release via execute-workflow instead of inlining#63
Merged
ci: dispatch beta release via execute-workflow instead of inlining#63
Conversation
PyPI's Trusted Publishing rejects OIDC tokens issued from reusable workflows, so the beta release jobs are inlined into on_master.yaml instead of being invoked via `uses:` from manual_release_beta.yaml.
vdusek
added
t-tooling
vdusek
changed the title
vdusek
added a commit
to apify/crawlee-python
that referenced
this pull request
May 7, 2026
## Summary PyPI's Trusted Publishing rejects OIDC tokens issued from reusable workflows: > The claims in this token suggest that the calling workflow is a reusable workflow. Reusable workflows are not currently supported by PyPI's Trusted Publishing. `on_master.yaml` was invoking `manual_release_beta.yaml` via `uses:`, which made the OIDC token reflect a reusable workflow call. The same fix was applied in `apify/apify-shared-python#63`. ## Changes - `on_master.yaml`: inline the four beta release jobs (`release_prepare`, `changelog_update`, `pypi_publish`, `doc_release_post_publish`) directly, instead of calling `manual_release_beta.yaml` as a reusable workflow. - `manual_release_beta.yaml`: remove the `workflow_call` trigger (no longer invoked from another workflow) and add a comment explaining why the duplication exists. - Drop the unused `tag_name` output from `release_prepare` in both files. ## Follow-up The PyPI Trusted Publisher for `crawlee` is currently configured for `manual_release_beta.yaml`. After this is merged, an entry for `on_master.yaml` needs to be added on PyPI so the automatic beta release passes verification. See: https://docs.pypi.org/trusted-publishers/troubleshooting/#reusable-workflows-on-github
Use apify/workflows/execute-workflow@main to trigger manual_release_beta.yaml as a separate workflow run (not a reusable workflow call), so PyPI's Trusted Publishing accepts the OIDC token. This removes the duplication between on_master.yaml and manual_release_beta.yaml introduced by the previous inline approach. Add a concurrency group to manual_release_beta.yaml so two rapid pushes to master cannot race on the version bump and PyPI publish. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
janbuchar
approved these changes
May 7, 2026
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the inlined beta release jobs in
on_master.yamlwith a single job that dispatchesmanual_release_beta.yamlviaapify/workflows/execute-workflow@main. The dispatched run is a regularworkflow_dispatch(not a reusable workflow call), so PyPI's Trusted Publishing accepts the OIDC token, and the duplication is gone.Also adds a
concurrency: releasegroup tomanual_release_beta.yamlso two rapid pushes to master cannot race on the version bump and PyPI publish.Same pattern as
apify-client-js,apify-sdk-js,apify-cli, andcrawlee.