ci: skip rebuild and duplicate CloudFront invalidation on nginx.conf-only pushes#2721
Open
markubra wants to merge 1 commit into
Open
ci: skip rebuild and duplicate CloudFront invalidation on nginx.conf-only pushes#2721markubra wants to merge 1 commit into
markubra wants to merge 1 commit into
Conversation
Contributor
|
✅ Preview for this PR (commit |
…nx.conf-only pushes docs.yaml runs on every master push and invalidates CloudFront, while deploy-nginx.yml already deploys and invalidates on nginx.conf changes - so a commit touching only nginx.conf invalidated the same distribution twice and triggered a pointless content rebuild. Ignore nginx.conf here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
markubra
force-pushed
the
ci/docs-skip-nginx-only-invalidation
branch
from
5f09772 to
1ce310e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A push touching only
nginx.conftriggered bothdocs.yaml(fires on every master push → invalidates CloudFront) anddeploy-nginx.yml(fires on thenginx.confpath → deploys nginx and invalidates), so the same distribution (E35XFW5797FGPU) was invalidated twice and the docs content was rebuilt for no reason.paths-ignore: nginx.confhere songinx.conf-only commits are handled solely by the nginx deploy path, which invalidates after the rollout.Pairs with apify/apify-docs-private#78.
🤖 Generated with Claude Code