refactor: drop only-allow preinstall, enforce pnpm via devEngines#2519
Open
B4nan wants to merge 1 commit into
Open
refactor: drop only-allow preinstall, enforce pnpm via devEngines#2519B4nan wants to merge 1 commit into
B4nan wants to merge 1 commit into
Conversation
|
✅ Preview for this PR (commit |
github-actions
Bot
added
the
t-tooling
The "preinstall": "npx only-allow pnpm" script ships in the published npm tarball and fires when downstream consumers install this package via npm/yarn. In the `npm install -g apify-cli` flow the npx bootstrap of only-allow fails to put the binary on PATH in time, breaking the global install (exit 127 on Linux, exit 1 on Windows). Replaces with devEngines.packageManager (Node 22+/npm 10+) with onFail:warn. This keeps the developer-visible signal that pnpm is expected without breaking CI steps that indirectly invoke npm (pnpm v10 shells to npm for `pnpm version`, `pnpm config`, etc.). devEngines is only checked at the package's own repo root, never on transitive installs, so downstream consumers stay unaffected. Mirrors apify/apify-client-js#895 + #896.
B4nan
force-pushed
the
fix/drop-only-allow-preinstall
branch
from
68c7061 to
3c56668
Compare
B4nan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
preinstall: npx only-allow pnpmscript ships in the published npm tarball and fires when downstream consumers install this package via npm/yarn. In thenpm install -g apify-cliflow the npx bootstrap ofonly-allowfails to put the binary on PATH in time:sh: 1: only-allow: not found(exit 127)'only-allow' is not recognized as an internal or external command(exit 1)Replaces with
devEngines.packageManager(Node 22+/npm 10+) withonFail: "warn". This keeps the developer-visible signal without breaking CI steps that indirectly invoke npm (pnpm v10 shells to npm forpnpm version,pnpm config, etc.).devEnginesis only checked at the package's own repo root, never on transitive installs, so downstream consumers are unaffected.Mirrors apify/apify-client-js#895 + #896.