-
Notifications
You must be signed in to change notification settings - Fork 189
docs(openapi): Document 404 related errors on acts and actor-builds endpoints
#2308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e43a091
Document 404 related errors on acts endpoints
Pijukatel 1cf995a
Use response schema in actor-builds endpoint as well
Pijukatel f16d5e5
Merge remote-tracking branch 'origin/master' into improve-errors-on-a…
Pijukatel 560a4c8
Remove redundant `allOf` from error response schemas
Pijukatel a3f2155
Remove redudant `oneOf`s
Pijukatel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
85 changes: 85 additions & 0 deletions
85
apify-api/openapi/components/schemas/common/errors/ActorErrors.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| ActorNotFoundError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [actor-not-found] | ||
| message: | ||
| type: string | ||
| enum: [Actor was not found] | ||
|
|
||
| ActorBuildNotFoundError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [record-not-found] | ||
| message: | ||
| type: string | ||
| enum: [Actor build was not found] | ||
|
|
||
| ActorRunNotFoundError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [record-not-found] | ||
| message: | ||
| type: string | ||
| enum: [Actor run was not found] | ||
|
|
||
| ActorRunTimeoutExceededError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [run-timeout-exceeded] | ||
| message: | ||
| type: string | ||
| pattern: '^Actor run exceeded the timeout of \d+ seconds for this API endpoint' | ||
| example: Actor run exceeded the timeout of 300 seconds for this API endpoint | ||
|
|
||
| ActorRunFailedError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [run-failed] | ||
| message: | ||
| type: string | ||
| pattern: '^Actor run did not succeed \(run ID: .+, status: .+\)' | ||
| example: "Actor run did not succeed (run ID: 55uatRrZib4xbZs, status: FAILED)" | ||
|
|
||
| ActorVersionNotFoundError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [record-not-found] | ||
| message: | ||
| type: string | ||
| enum: [Actor version was not found] | ||
13 changes: 13 additions & 0 deletions
13
apify-api/openapi/components/schemas/common/errors/BuildErrors.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| UnknownBuildTagError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [unknown-build-tag] | ||
| message: | ||
| type: string | ||
| enum: [Build with tag \"latest\" was not found. Has the Actor been built already?] |
13 changes: 13 additions & 0 deletions
13
apify-api/openapi/components/schemas/common/errors/EnvVariableErrors.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| EnvironmentVariableNotFoundError: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| error: | ||
| type: object | ||
| properties: | ||
| type: | ||
| type: string | ||
| enum: [record-not-found] | ||
| message: | ||
| type: string | ||
| enum: [Environment variable was not found] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,7 +53,12 @@ get: | |
| "403": | ||
| $ref: ../../components/responses/Forbidden.yaml | ||
| "404": | ||
| $ref: ../../components/responses/NotFound.yaml | ||
| description: Not found - the requested resource was not found. | ||
| content: | ||
| application/json: | ||
| schema: | ||
| oneOf: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also seems redundant and the other files have it too 🙂
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed, where redundant |
||
| - $ref: "../../components/schemas/common/errors/ActorErrors.yaml#/ActorBuildNotFoundError" | ||
| deprecated: false | ||
| x-legacy-doc-urls: | ||
| - https://docs.apify.com/api/v2#/reference/actor-builds/build-object/get-build | ||
|
|
@@ -95,7 +100,12 @@ delete: | |
| "401": | ||
| $ref: ../../components/responses/Unauthorized.yaml | ||
| "404": | ||
| $ref: ../../components/responses/NotFound.yaml | ||
| description: Not found - the requested resource was not found. | ||
| content: | ||
| application/json: | ||
| schema: | ||
| oneOf: | ||
| - $ref: "../../components/schemas/common/errors/ActorErrors.yaml#/ActorBuildNotFoundError" | ||
| deprecated: false | ||
| x-legacy-doc-urls: | ||
| - https://docs.apify.com/api/v2#/reference/actor-builds/delete-build/delete-build | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.