Skip to content

fix: use 'is not None' checks for json parameter to preserve falsy values #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vdusek wants to merge 1 commit into from
Closed

fix: use 'is not None' checks for json parameter to preserve falsy values #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/apify_client/_http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@ def _prepare_request_call(
data: Any = None,
json: JSONSerializable | None = None,
) -> tuple[dict, dict | None, Any]:
if json and data:
if json is not None and data is not None:
raise ValueError('Cannot pass both "json" and "data" parameters at the same time!')

if not headers:
headers = {}

# dump JSON data to string, so they can be gzipped
if json:
if json is not None:
data = jsonlib.dumps(json, ensure_ascii=False, allow_nan=False, default=str).encode('utf-8')
headers['Content-Type'] = 'application/json'

Expand Down