Skip to content

fix: validate actors search choice flags - #1332

Open
kuntal1461 wants to merge 1 commit into
apify:masterfrom
kuntal1461:fix/actors-search-flag-validation
Open

fix: validate actors search choice flags#1332
kuntal1461 wants to merge 1 commit into
apify:masterfrom
kuntal1461:fix/actors-search-flag-validation

Conversation

@kuntal1461

Copy link
Copy Markdown

Checks:

  • pnpm run lint
  • pnpm run format
  • pnpm run build
  • pnpm run test:local

@patrikbraborec

Copy link
Copy Markdown
Contributor

Hey @kuntal1461, thanks for the contribution. This is great. Just quick question -> the name of pricing models are based on docs? Cc. @l2ysho - let's check if the pricing models are correct. Thanks!

@kuntal1461

Copy link
Copy Markdown
Author

Hi @patrikbraborec Thanks! I verified this against the Store API docs. The pricing model values used in this commit are the API enum values for the pricingModel filter: FREE, FLAT_PRICE_PER_MONTH, PRICE_PER_DATASET_ITEM, and PAY_PER_EVENT.
I also checked the commit behavior locally, and invalid values are now rejected by the CLI before the Store request is made. Happy to adjust if @l2ysho confirms a different source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

actors search: --pricing-model and --sort-by use options: instead of choices:, so they are never validated

3 participants