Conversation
The Windows ARM bun install downloaded install.ps1 into the repo checkout, leaving an untracked file that broke the next step's pnpm version clean-tree check. Write and run it from RUNNER_TEMP.
|
I did not like this idea of claude actually, after quick research probably |
|
Will this even be needed post my PR that fixes arm64 windows builds? |
Not fully sure, but |
Actually you fix it with that PR. Probably best thing to do, but lets keep in mind this new pnpm 11 behaviour. |
actually |
Alright, good to know :D |
|
Closing this due to #1169 |
…dle-build-stray-installps1-dirties-working-tree
pnpm 11's `pnpm version` aborts on an unclean working tree (ERR_PNPM_UNCLEAN_WORKING_TREE); the Windows ARM bun install leaves an untracked install.ps1 behind. pnpm 10 did not check by default. Pass --no-git-checks on the bundle-build version bump to restore that.
…ws-arm-bundle-build-stray-installps1-dirties-working-tree' into 1221-pnpm-version-fails-on-windows-arm-bundle-build-stray-installps1-dirties-working-tree
|
I will hot fix this as I am blocked in release process, revert and fix will be done in #1169 cc @patrikbraborec @DaveHanns |
Closes #1221.
The
Install bun (Windows ARM)step downloadedinstall.ps1into the repo checkout (cwd), leaving an untracked file. The next step'spnpm version … --allow-same-versionruns agit status --porcelainclean-tree check, which then aborts withERR_PNPM_UNCLEAN_WORKING_TREE— flakily, since a re-run starts clean.Fix: download and run the installer from
$env:RUNNER_TEMPinstead of the repo root, in bothrelease.yamlandpre_release.yaml. The working tree stays clean.