fix(ci): fix the monorepo#299
Open
nikitachapovskii-dev wants to merge 8 commits into
Open
Conversation
Contributor
Author
ruocco-l
approved these changes
Jun 16, 2026
ruocco-l
left a comment
Collaborator
There was a problem hiding this comment.
🚀 Thank you for figuring this out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the scrapers were split into this repo and the tooling was modernized (pnpm, oxlint, oxfmt), CI stopped working
The e2e hang and the red tests
Two problems were stacked on top of each other.
The job was hanging because
actions/setup-nodewithnode-version: 24had moved from 24.14.1 to 24.16.0, and on 24.16.0 (Linux)pnpm installnever exits once the dependency build scripts finish. It only shows up on a cold pnpm store. I bisected it in Docker: 24.15.0 is fine, 24.16.0 hangs, on every pnpm version. Fix is to pinnode-version: 24.15.0and addtimeout-minutesso any future hang fails fast instead of burning six hours in silence.The tests were also failing because the e2e workflow never installed browsers. On a warm pnpm store the side-effects cache skips the puppeteer/playwright postinstall, so Chrome was missing and every browser suite died with "Could not find Chrome". The PR workflow already had this step; the e2e one didn't, so I added it.
Release workflow
Added sitemap-extractor to the release matrix so it can be built and pushed like the other six. Everything else is unchanged, and stable stays the default channel.
Post-split cleanup
A few things the split left behind:
Verified
Full toolchain is green (build, oxlint, oxfmt, vitest, tsc). A manual e2e run on this branch with a cold cache passed (24 passed, 3 skipped) and finished in about 16 minutes.
Follow-ups (not in this PR)
ignoreSslErrorse2e suites got slower after the crawlee/apify bump (more retry time against badssl.com). Not a correctness problem, but worth a look.