feat: release v1.0.0 - #19
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe changelog adds a 1.0.0 release entry and updates its commits URL. Package metadata and the rockspec adopt the API7 package name, semantic version, repository link, and 1.0.0 source tag. ChangesRelease metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
308e948 to
c68ca4f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rockspec/nginx-lua-prometheus-api7-0.20260728-1.rockspec`:
- Around line 4-8: Update the rockspec version and corresponding source tag in
the release metadata to the intended 0.20260727 release, ensuring the declared
filename/version matches the release workflow’s expected upload artifact. If
retaining 0.20260728 instead, update the release objective and commit metadata
and ensure that tag exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 35653dca-54c5-43ca-90e2-49822a5600af
📒 Files selected for processing (1)
rockspec/nginx-lua-prometheus-api7-0.20260728-1.rockspec
c68ca4f to
78780e3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 7-17: Synchronize the release identifiers to 0.20260728: update
CHANGELOG.md lines 7-17 from 1.0.0 to 0.20260728, update
rockspec/nginx-lua-prometheus-api7-1.0.0-1.rockspec lines 4-8 so the package
version and source tag use 0.20260728, and synchronize dist.ini before upload.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3717cbec-f3c0-4a5c-8088-d0af7c2caca2
📒 Files selected for processing (2)
CHANGELOG.mdrockspec/nginx-lua-prometheus-api7-1.0.0-1.rockspec
78780e3 to
13987a8
Compare
There was a problem hiding this comment.
Pull request overview
This PR prepares the first semantic-versioned release (v1.0.0) of the nginx-lua-prometheus-api7 fork, aligning release metadata (rockspec, dist config, and changelog) with the new versioning scheme and documenting the included fix from #18.
Changes:
- Bump the LuaRocks rockspec version/tag to
1.0.0. - Update
dist.iniversion to1.0.0. - Add a
1.0.0section to the changelog describing the semver switch and #18.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rockspec/nginx-lua-prometheus-api7-1.0.0-1.rockspec | Updates LuaRocks package version/tag for the 1.0.0 release. |
| dist.ini | Updates distribution metadata version to 1.0.0. |
| CHANGELOG.md | Documents the 1.0.0 release and the semver scheme change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
13987a8 to
8bd0ea3
Compare
8bd0ea3 to
493d70f
Compare
First release of this fork under semantic versioning, shipping #18 (
fix(keys): reclaim expired shared-dict entries in remove_expired_keys()), which was merged after0.20260716was cut and is in no released version yet.Why 1.0.0 (scheme change)
Earlier releases used the upstream date-based scheme (
0.YYYYMMDD). Upstream (knyar) is dormant — last release0.20240525(2024-05), last commit 2025-01 — and this fork is now maintained independently, so versions no longer track upstream snapshots. Switching to semver aligns with every other Lua dependency in the apisix/EE rockspecs (all semver).First semver release must be
1.0.0, not0.x: luarocks compares by component, and0.xwould sort below the existing0.2026xxxxdate versions and be treated as a downgrade. Date-based tags before1.0.0are kept as-is.Changes since 0.20260716
remove_expired_keys()now callsdict:flush_expired()so expired entries are reclaimed, fixing the shm step-down-until-full behavior (bug: Prometheus shared dict free_space drops periodically when metric expire is enabled apache/apisix#13658).Release mechanism
Squash-merge keeping the title
feat: release v1.0.0; theReleaseworkflow matches^feat: release v*(\S+), tags1.0.0, and uploads the rockspec to luarocks. The workflow is version-format-agnostic, so no CI change is needed.Downstream (after luarocks upload)
1.0.0in apache/apisix and api7-ee-3-gateway rockspecs, withFixes #13658.0.20260716, which predates this fix).Summary by CodeRabbit