ci: add performance regression gate with criterion benchmarks#157
Conversation
|
Warning Review limit reached
More reviews will be available in 54 minutes and 23 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Remove unused submodules checkout option - Add comments explaining workflow permissions - Add SAFETY comments for unsafe FFI calls in benchmarks - Add doc comment explaining field_access benchmarks measure FFI overhead
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Closes #151
Add automated performance regression detection to CI using criterion benchmarks and benchmark-action.
Changes
__bench_apimodule exposing internalDocument,Options,QJSON_MODE_LAZYfor benchmark usebenches/rust_bench.rswith three benchmark groups:parse_eager- eager mode parsing across 3 fixturesparse_lazy- lazy mode parsing across 3 fixturesfield_access- FFI field access operations (get_str, get_f64, nested paths).github/workflows/bench.ymlCI workflow that:make bench-rusttargetTesting
cargo bench --bench rust_bench -- --test)Notes