Support incremental executionId in runInLoop#227
Merged
matejfalat merged 2 commits intomainfrom Feb 20, 2026
Merged
Conversation
Siegrift
approved these changes
Feb 20, 2026
Collaborator
Siegrift
left a comment
Siegrift
left a comment
There was a problem hiding this comment.
LGTM with minor comments
| /** | ||
| * Optional prefix prepended to the incrementing number (e.g. "my-prefix-0"). | ||
| */ | ||
| prefix?: string; |
Collaborator
There was a problem hiding this comment.
I was thinking we could have also added a start counter. E.g. you want to start from the current timestamp, but then realized you could just specify it as a prefix and also add a separator, e.g. 1771580212- which would make logs more readable.
Contributor
Author
There was a problem hiding this comment.
Hmm, I mean it's trivial to add start option as well, but I can't really see a use case for it (as you noted, block numbers/timestamps are better in the prefix) 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related https://github.com/api3dao/oev-searcher/issues/2663
This PR adds support for incremental executionIds with a custom prefix.